[Mesa-dev] [PATCH 1/3] autoconf: pass -Wall to automake

Kenneth Graunke kenneth at whitecape.org
Mon Apr 23 13:46:31 PDT 2012


On 04/22/2012 01:43 AM, nobled wrote:
> And fix these warning that appear at autoreconf time:
> "`:='-style assignments are not portable"
> ---
>   configure.ac                               |    2 +-
>   src/gallium/drivers/r300/Makefile.sources  |    2 +-
>   src/mesa/drivers/dri/i915/Makefile.sources |    4 ++--
>   src/mesa/drivers/dri/i965/Makefile.sources |    8 ++++----
>   4 files changed, 8 insertions(+), 8 deletions(-)

You'll also want to change the := in the Radeon drivers:

src/gallium/drivers/r300/Makefile.sources
src/gallium/drivers/r600/Makefile.sources

Otherwise, looks good to me.  Extra autoconf/automake warnings are 
probably a good idea.


More information about the mesa-dev mailing list