[Mesa-dev] [PATCH] glsl: Remove unused member predicate from ir_dead_functions_visitor.

Ian Romanick idr at freedesktop.org
Fri Apr 27 02:18:22 PDT 2012


On 04/27/2012 06:17 AM, Vinson Lee wrote:
> Fix uninitialized pointer field defect reported by Coverity.
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>

It looks like this field was never used in this module.  I suspect that 
it was a copy-and-paste carry over.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   src/glsl/opt_dead_functions.cpp |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/glsl/opt_dead_functions.cpp b/src/glsl/opt_dead_functions.cpp
> index 017a286..f503493 100644
> --- a/src/glsl/opt_dead_functions.cpp
> +++ b/src/glsl/opt_dead_functions.cpp
> @@ -62,8 +62,6 @@ public:
>
>      signature_entry *get_signature_entry(ir_function_signature *var);
>
> -   bool (*predicate)(ir_instruction *ir);
> -
>      /* List of signature_entry */
>      exec_list signature_list;
>      void *mem_ctx;



More information about the mesa-dev mailing list