[Mesa-dev] [PATCH] r600g: Set EVERGREEN_LOOP_CONST_END to the correct value

[Tom Stellard]

On Fri, Apr 27, 2012 at 04:59:40PM -0400, Alex Deucher wrote:
> On Fri, Apr 27, 2012 at 3:12 PM, Tom Stellard <tstellar at gmail.com> wrote:
> > The SQ_LOOP_CONST_* registers range from SQ_LOOP_CONST_0 to
> > SQ_LOOP_CONST_191.
> > ---
> >  src/gallium/drivers/r600/evergreend.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/gallium/drivers/r600/evergreend.h b/src/gallium/drivers/r600/evergreend.h
> > index 7e2dcea..98c96ed 100644
> > --- a/src/gallium/drivers/r600/evergreend.h
> > +++ b/src/gallium/drivers/r600/evergreend.h
> > @@ -35,7 +35,7 @@
> >  #define EVERGREEN_RESOURCE_END                      0x00034000
> >  #define CAYMAN_RESOURCE_END                         0x00038000
> >  #define EVERGREEN_LOOP_CONST_OFFSET                 0x0003A200
> > -#define EVERGREEN_LOOP_CONST_END                    0x0003A26C
> > +#define EVERGREEN_LOOP_CONST_END                    0x0003A4FC
> 
> Shouldn't that be 0x3a500?  The _END is treated as exclusive IIRC.
>

You're right _END is exclusive.

> >  #define EVERGREEN_BOOL_CONST_OFFSET                 0x0003A500
> >  #define EVERGREEN_BOOL_CONST_END                    0x0003A506
> >  #define CAYMAN_BOOL_CONST_END                       0x0003A518
> 
> Actually it looks like several of these are wrong.
> 
> 
> diff --git a/src/gallium/drivers/r600/evergreend.h
> b/src/gallium/drivers/r600/evergreend.h
> index 4009e91..105d80f 100644
> --- a/src/gallium/drivers/r600/evergreend.h
> +++ b/src/gallium/drivers/r600/evergreend.h
> @@ -32,20 +32,16 @@
>  #define EVERGREEN_CONTEXT_REG_OFFSET                0X00028000
>  #define EVERGREEN_CONTEXT_REG_END                   0X00029000
>  #define EVERGREEN_RESOURCE_OFFSET                   0x00030000
> -#define EVERGREEN_RESOURCE_END                      0x00034000
> -#define CAYMAN_RESOURCE_END                         0x00038000
> +#define EVERGREEN_RESOURCE_END                      0x00038000
>  #define EVERGREEN_LOOP_CONST_OFFSET                 0x0003A200
> -#define EVERGREEN_LOOP_CONST_END                    0x0003A26C
> +#define EVERGREEN_LOOP_CONST_END                    0x0003A500
>  #define EVERGREEN_BOOL_CONST_OFFSET                 0x0003A500
> -#define EVERGREEN_BOOL_CONST_END                    0x0003A506
> -#define CAYMAN_BOOL_CONST_END                       0x0003A518
> +#define EVERGREEN_BOOL_CONST_END                    0x0003A518
>  #define EVERGREEN_SAMPLER_OFFSET                    0X0003C000
> -#define EVERGREEN_SAMPLER_END                       0X0003CFF0
> -#define CAYMAN_SAMPLER_END                          0X0003C600
> +#define EVERGREEN_SAMPLER_END                       0X0003C600
> 
>  #define EVERGREEN_CTL_CONST_OFFSET                  0x0003CFF0
> -#define EVERGREEN_CTL_CONST_END                     0x0003E200
> -#define CAYMAN_CTL_CONST_END                        0x0003FF0C
> +#define EVERGREEN_CTL_CONST_END                     0x0003FF0C
> 
>  #define EVENT_TYPE_PS_PARTIAL_FLUSH            0x10
>  #define EVENT_TYPE_ZPASS_DONE                  0x15
> 

I'll make these changes too.

-Tom

> 
> 
> > --
> > 1.7.7.6
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>