[Mesa-dev] [PATCH 3/3] mesa: generate GL_INVALID_VALUE when bufSize < 0

[Brian Paul]

On Sun, Apr 29, 2012 at 9:06 AM, nobled <nobled at dreamwidth.org> wrote:
> On Tue, Apr 24, 2012 at 9:29 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 04/22/2012 09:44 AM, nobled wrote:
>>>
>>> Though not explicit in the GL_ARB_robustness extension,
>>> the GL standard says:
>>>
>>>   If a negative number is provided where an argument of type sizei or
>>>   sizeiptr is specified, the error INVALID_VALUE is generated.
>>>
>>> While the extension says that GL_INVALID_OPERATION is given
>>> when the required space is "greater than<bufSize>", and this
>>
>>
>> Which error do other implementations generate?  If there's a clear trend, we
>> should follow that.  If there's not a clear trend, I can file a bug against
>> the spec for being ambiguous.
> I'm still waiting for someone who can use the proprietary drivers to
> test the piglit patch I sent out a week ago.

Here's what I see with NVIDIA's driver:

$ bin/arb_robustness_client-mem-bounds -auto
Unexpected GL error: GL_INVALID_OPERATION 0x502
(Error at /home/brian/projects/piglit/tests/spec/arb_robustness/client-mem-bounds.c:62)
Expected GL error: GL_INVALID_VALUE 0x501
(bufSize = -2147483520, expected 128 bytes to be required)
PIGLIT: {'result': 'fail' }


-Brian