[Mesa-dev] [PATCH 4/4] i965/vs: Don't clobber sampler message MRFs with subexpressions.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> See the preceding commit for a description of the problem.
>
> NOTE: This is a candidate for stable release branches.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52129
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 60 ++++++++++++++++++--------
>  1 file changed, 43 insertions(+), 17 deletions(-)
>
> No observed benefit to this patch, at least in Piglit, but it certainly
> is worth doing.
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index c77dc91..03089d0 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

> +   src_reg lod, dPdy;
> +   switch (ir->op) {
> +   case ir_txf:
> +   case ir_txl:
> +   case ir_txs:
> +      ir->lod_info.lod->accept(this);
> +      lod = this->result;
> +      break;
> +   case ir_txd:
> +      ir->lod_info.grad.dPdx->accept(this);
> +      lod = this->result;
> +
> +      ir->lod_info.grad.dPdy->accept(this);
> +      dPdy = this->result;
> +      break;
> +   case ir_tex:
> +   case ir_txb:
> +      break;
> +   }

> -
> -	 ir->lod_info.grad.dPdx->accept(this);
> -	 src_reg dPdx = this->result;
> -	 ir->lod_info.grad.dPdy->accept(this);
> -	 src_reg dPdy = this->result;
> +	 src_reg &dPdx = lod;

Could dPdx get declared and set up above next to dPdy?

Other than that and the commit message note on 2/4,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/07a32bf7/attachment.pgp>