[Mesa-dev] [PATCH 2/4] i965/fs: Factor out texcoord setup into a helper function.
Eric Anholt
eric at anholt.net
Mon Aug 6 09:50:36 PDT 2012
Kenneth Graunke <kenneth at whitecape.org> writes:
> With the textureRect support and GL_CLAMP workarounds, it's grown
> sufficiently that it deserves its own function. Separating it out
> makes the original function much more readable.
This looks good.
> While we're refactoring it, tidy up a conditional. Instead of:
>
> if (gen < 6 && rect)
> ...
> else if (rect)
> ...
>
> We can do the more readable:
>
> if (rect) {
> if (gen < 6)
> ...
> else
> ...
> }
I don't see this having actually happened in this commit. Which I'm
fine with, just as long as the commit message and code are consistent :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/3d70c1ca/attachment.pgp>
More information about the mesa-dev
mailing list