[Mesa-dev] [PATCH 05/16] i965: Add functions up/downsampling on miptrees (v2)

Eric Anholt eric at anholt.net
Mon Aug 6 11:10:10 PDT 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> These functions do an up or downsample between mt and mt->singlesample_mt.
>
> Conceptually, these functions belong in intel_mipmap_tree.c. However, they
> needs to interact with blorp, which is C++. So I created a new file,
> brw_blorp_orphans.cpp, for these and other functions that fall into the
> same category.
>
> v2:
>     - Add an upsample function.
>     - Also up/downsample the stencil miptree.
>     - Assert that the miptree is "flat".

Couldn't we just make a brw_blorp_blit(brw, src_mt, dst_mt, ...)
function in the brw_blorp_blit file.cpp, which do_blorp_blit could use,
and then we wouldn't need to put this code in a weird file?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/904ee69d/attachment.pgp>


More information about the mesa-dev mailing list