[Mesa-dev] [PATCH 11/16] intel: Support mapping multisample miptrees

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/06/2012 11:35 AM, Eric Anholt wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
> 
>> Add two new functions: intel_miptree_{map,unmap}_multisample, to which 
>> intel_miptree_{map,unmap} dispatch. Only mapping flat, renderbuffer-like 
>> miptrees are supported.
> 
>> void @@ -1513,5 +1606,8 @@ intel_miptree_unmap(struct intel_context
>> *intel, unsigned int level, unsigned int slice) { -
>> intel_miptree_unmap_singlesample(intel, mt, level, slice); +   if
>> (mt->num_samples == 0)
> 
> Isn't mt->num_samples sometimes 1 for a singlesample mt now?

Correct. Fixed in series v3.

> 
>> +      intel_miptree_unmap_singlesample(intel, mt, level, slice); +
>> else +      intel_miptree_unmap_multisample(intel, mt, level, slice); }
> 
> Other than that, downsamples get done in some cases where needs 
> needs_downsample was false, which is suboptimal.  But I think the code is
> correct, and this is a fallback path so I don't care too much.
> 

Yeah... but since you pointed it out, I could not help but fix it. Unnecessary
downsamples are removed in series v3.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJQIF/jAAoJEAIvNt057x8iUwkQAL3mvrOnGrGwO0Qi/udjjO5k
9u2CK7JGP9EoljvhgF5sqcyLWAHnuNKCpEE4EVeb3FbkuU40yQgiMXRLuPVrKMWL
YqAJZozW+MtdgLtBi4OaEobx3A7bA2CvwO3o6csM1eS7MWgX6Fe9aL8BMWPK52cH
2VYhSz2DPY/bGgV7KU3+grMeZ4R6rZdnX9icIvdGEmd8IWJ3XrdLOqUf1U0EdUbQ
matZmdAd65x8oV6egWI87E9PQgyZwsLLx8YB/+LE3M3giuqIOkDnKwqx7PMMSICl
xn51wU3a1lgznTr8xlLgc52KoRTMJ/rd+8vqSKmzgRA4Novoj8FOMMKXLsoJC5oH
HOYp8qPhclv95v3HEntpRdjaB47VeLZvXgm+xuQL/eyPZV+SzbHmcY2cUbcDFwFN
tAv9T4Lbl6ptqVnL6m/OKJf36kT0plWtnZYQMOH82ClMjhjqcGmF0KNguLzSU+9B
uEezumEvKJhHdvvrF2U8IBSuCTz4o0dHEHKC8fOh/qXDSi/Zblmki/yQZfq4Pobi
BmOEi3kJwIVbSHAWvjbn0S+oVBrAA17qtH4ZDXMqgHl85EhuHXTSayda4lNbObJ5
wO2BRbNZBDAufytqE/9yJlL/Wxv8yPjKd2Jy/a0Q9CrI/vQtc+fdon8M9yybK0jU
4w6wcGB/xwekzJLy+xuj
=+KyW
-----END PGP SIGNATURE-----