[Mesa-dev] [PATCH 19/22] i965/vs: Communicate the pull constant block read parameters through src_regs.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> On 07/31/2012 03:01 PM, Eric Anholt wrote:
>> Similar to the previous commit for the fragment shader.
>> ---
>>  src/mesa/drivers/dri/i965/brw_vec4.h           |    3 ++-
>>  src/mesa/drivers/dri/i965/brw_vec4_emit.cpp    |   19 ++++++++++++-------
>>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |    5 +++--
>>  3 files changed, 17 insertions(+), 10 deletions(-)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h
>> index 920d703..deac55d 100644
>> --- a/src/mesa/drivers/dri/i965/brw_vec4.h
>> +++ b/src/mesa/drivers/dri/i965/brw_vec4.h
>> @@ -476,7 +476,8 @@ public:
>>  			      struct brw_reg index);
>>     void generate_pull_constant_load(vec4_instruction *inst,
>>  				    struct brw_reg dst,
>> -				    struct brw_reg index);
>> +				    struct brw_reg index,
>> +				    struct brw_reg offset);
>
> Commit message says "through src_regs."  These are brw_regs.
>
> Other than that, this looks fine.
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Yeah, we were already communicating offset through a src_reg as src0 of
VS_OPCODE_PULL_CONSTANT, it's the introduction of the surface index as a
src_reg that changed here.  Too much copy and paste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/d4652a19/attachment.pgp>