[Mesa-dev] [PATCH 14/15] intel: Clarify intel_screen_make_configs

Eric Anholt eric at anholt.net
Mon Aug 6 19:40:10 PDT 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> This function felt sloppy, so this patch cleans it up a little bit.
>
> - Rename `color` to `i`. It is not a color value, only an iterator int.

I'm meh on this change.

> - Move `depth_bits[0] = 0` into the non-accum loop because that is where
>   it used. The accum loop later overwrites depth_bits[0].

This makes sense -- move it next to the place that sets up the rest of
the array.

> - Redefine `msaa_samples_array` as static const because it is never
>   modified.

Maybe instead, singlesample_samples[] = {0} and multisample_samples[] =
{4, 8}?  The array math in the next patch was not pretty.

Feel free to ignore me on this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/8df0788b/attachment.pgp>


More information about the mesa-dev mailing list