[Mesa-dev] [PATCH 2/4] svga: remove unused svga_shader::use_sm30 field, add comments

Brian Paul brianp at vmware.com
Wed Aug 8 08:10:35 PDT 2012


---
 src/gallium/drivers/svga/svga_context.h |    4 +---
 src/gallium/drivers/svga/svga_tgsi.h    |    9 ++++++++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium/drivers/svga/svga_context.h
index 7567431..f243b4f 100644
--- a/src/gallium/drivers/svga/svga_context.h
+++ b/src/gallium/drivers/svga/svga_context.h
@@ -57,9 +57,7 @@ struct svga_shader
 
    struct svga_shader_result *results;
 
-   unsigned id;
-
-   boolean use_sm30;
+   unsigned id;  /**< for debugging only */
 };
 
 struct svga_fragment_shader
diff --git a/src/gallium/drivers/svga/svga_tgsi.h b/src/gallium/drivers/svga/svga_tgsi.h
index bb0c6d0..0e06dbf 100644
--- a/src/gallium/drivers/svga/svga_tgsi.h
+++ b/src/gallium/drivers/svga/svga_tgsi.h
@@ -79,6 +79,12 @@ struct svga_compile_key {
    int8_t generic_remap_table[MAX_GENERIC_VARYING];
 };
 
+
+/**
+ * A single TGSI shader may be compiled into different variants of
+ * SVGA3D shaders depending on the compile key.  Each user shader
+ * will have a linked list of these results.
+ */
 struct svga_shader_result
 {
    const struct svga_shader *shader;
@@ -92,7 +98,8 @@ struct svga_shader_result
    const unsigned *tokens;
    unsigned nr_tokens;
 
-   /* SVGA Shader ID:
+   /** Per-context shader identifier used with SVGA_3D_CMD_SHADER_DEFINE,
+    * SVGA_3D_CMD_SET_SHADER and SVGA_3D_CMD_SHADER_DESTROY.
     */
    unsigned id;
    
-- 
1.7.3.4



More information about the mesa-dev mailing list