[Mesa-dev] [PATCH 1/3] i965: Add a safety check for brw_set_saturate().

Eric Anholt eric at anholt.net
Wed Aug 8 15:08:09 PDT 2012


There is an easy chance for bugs in brw_wm_emit.c, where you would pass 1 << 5
instead of 1, which would get truncated to 0.
---
 src/mesa/drivers/dri/i965/brw_eu.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c
index 2c432a9..7697d08 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.c
+++ b/src/mesa/drivers/dri/i965/brw_eu.c
@@ -143,6 +143,7 @@ void brw_set_mask_control( struct brw_compile *p, GLuint value )
 
 void brw_set_saturate( struct brw_compile *p, GLuint value )
 {
+   assert(value == 0 || value == 1);
    p->current->header.saturate = value;
 }
 
-- 
1.7.10.4



More information about the mesa-dev mailing list