[Mesa-dev] [PATCH 03/19] gallium: make pipe_box signed in order to represent flipped blits

[Roland Scheidegger]

Am 10.08.2012 00:37, schrieb Marek Olšák:
> I'd like to have either signed pipe_box or a new struct for that purpose.
It looks to me like conceptually what you want is more like a coordinate
pair. I dunno though but negative width/height/depth just aren't very
intuitive for a box. But maybe I'm the only one caring about that style :-).


> 
> I assume transfers and resource_copy_region will always be unsigned.
> 
> x,y,z don't have to be signed, good point.
More room for unsigned/signed arithmetic mistakes though if they aren't
the same :-).

Roland


> 
> Marek
> 
> On Thu, Aug 9, 2012 at 10:38 PM, Roland Scheidegger <sroland at vmware.com> wrote:
>> I'm not convinced this is a good idea.
>> That dilutes the meaning of a "box" quite a bit (and I don't think x/y/z
>> can actually be negative?). There are presumably also quite a lot of
>> uses of pipe_box which might not be able to deal with such boxes.
>>
>> Roland
>>
>>
>>
>> Am 09.08.2012 18:07, schrieb Marek Olšák:
>>> This will be used by u_blitter.
>>> ---
>>>  src/gallium/include/pipe/p_state.h |   12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
>>> index c828c80..76559ad 100644
>>> --- a/src/gallium/include/pipe/p_state.h
>>> +++ b/src/gallium/include/pipe/p_state.h
>>> @@ -387,12 +387,12 @@ struct pipe_sampler_view
>>>   */
>>>  struct pipe_box
>>>  {
>>> -   unsigned x;
>>> -   unsigned y;
>>> -   unsigned z;
>>> -   unsigned width;
>>> -   unsigned height;
>>> -   unsigned depth;
>>> +   int x;
>>> +   int y;
>>> +   int z;
>>> +   int width;
>>> +   int height;
>>> +   int depth;
>>>  };
>>>
>>>
>>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev