[Mesa-dev] [PATCH] mesa: raise GL_INVALID_OPERATION in glGenerateMipmap for missing base image

[Jose Fonseca]

Seems alright to me.

Jose

----- Original Message -----
> This seems to be expected by the WebGL texture-mips test.  The error
> makes
> sense, but I haven't found (yet) any OpenGL documentation specifying
> this
> error condition.
> 
> See https://bugs.freedesktop.org/show_bug.cgi?id=44912
> 
> Note: This is a candidate for the 8.0 branch.
> ---
>  src/mesa/main/fbobject.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index d558d7f..d4fef28 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -2561,6 +2561,8 @@ _mesa_GenerateMipmapEXT(GLenum target)
>     srcImage = _mesa_select_tex_image(ctx, texObj, target,
>     texObj->BaseLevel);
>     if (!srcImage) {
>        _mesa_unlock_texture(ctx, texObj);
> +      _mesa_error(ctx, GL_INVALID_OPERATION,
> +                  "glGenerateMipmap(zero size base image)");
>        return;
>     }
>  
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>