[Mesa-dev] [PATCH] intel: use _mesa_meta_Clear with OpenGL ES 1.1 v3

[Tapani Pälli]

On 08/09/2012 06:51 PM, Eric Anholt wrote:
> Tapani Pälli <tapani.palli at intel.com> writes:
> 
>> Patch changes i915 and i965 drivers to use fixed function version of
>> meta clear when running on ES 1.1. This fixes rendering errors seen with
>> Google Maps, Angry Birds and Gallery3D on Android platform.
>>
>> Change 88128516d43be5d25288ff5b64db63cda83c04b3 exposes all extensions
>> internally to be available independent of GL flavour, therefore check
>> against ARB_fragment_shader does not work.
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>> Reviewed-by: Eric Anholt <eric at anholt.net>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50333
>> ---
>>  src/mesa/drivers/dri/i915/intel_clear.c | 6 +++---
>>  src/mesa/drivers/dri/i965/brw_clear.c   | 7 ++++++-
>>  2 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i915/intel_clear.c b/src/mesa/drivers/dri/i915/intel_clear.c
>> index 96d9c8f..ebac0f5 100644
>> --- a/src/mesa/drivers/dri/i915/intel_clear.c
>> +++ b/src/mesa/drivers/dri/i915/intel_clear.c
>> @@ -179,10 +179,10 @@ intelClear(struct gl_context *ctx, GLbitfield mask)
>>  
>>     if (tri_mask) {
>>        debug_mask("tri", tri_mask);
>> -      if (ctx->Extensions.ARB_fragment_shader)
>> -	 _mesa_meta_glsl_Clear(&intel->ctx, tri_mask);
>> -      else
>> +      if (ctx->API == API_OPENGLES)
>>  	 _mesa_meta_Clear(&intel->ctx, tri_mask);
>> +      else
>> +	 _mesa_meta_glsl_Clear(&intel->ctx, tri_mask);
>>     }
>>  }
> 
> Argh, I missed this before..
> 
> This will break clears on 8xx, which doesn't have ARB_fragment_shader.
> 

OK, I will additional check against ARB_fragment_shader, don't have 8xx
to test clears though ...


-- 

// Tapani


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 554 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120813/e0497504/attachment-0001.pgp>