[Mesa-dev] [PATCH 12/26] mesa/es: Remove redundant clear bitmask validation

[Kenneth Graunke]

On 08/17/2012 08:11 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> ---
>  src/mesa/main/APIspec.xml |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
> index 53d9aa9..606e546 100644
> --- a/src/mesa/main/APIspec.xml
> +++ b/src/mesa/main/APIspec.xml
> @@ -680,17 +680,6 @@
>  		<return type="void"/>
>  		<param name="mask" type="GLbitfield"/>
>  	</proto>
> -
> -	<desc name="mask" error="GL_INVALID_VALUE">
> -		<value name="0"/>
> -		<value name="(GL_COLOR_BUFFER_BIT)"/>
> -		<value name="(GL_DEPTH_BUFFER_BIT)"/>
> -		<value name="(GL_STENCIL_BUFFER_BIT)"/>
> -		<value name="(GL_COLOR_BUFFER_BIT|GL_DEPTH_BUFFER_BIT)"/>
> -		<value name="(GL_COLOR_BUFFER_BIT|GL_STENCIL_BUFFER_BIT)"/>
> -		<value name="(GL_DEPTH_BUFFER_BIT|GL_STENCIL_BUFFER_BIT)"/>
> -		<value name="(GL_COLOR_BUFFER_BIT|GL_DEPTH_BUFFER_BIT|GL_STENCIL_BUFFER_BIT)"/>

Way to go, enumerating every possible combination...now that is quality
code :)

> -	</desc>
>  </template>
>  
>  <template name="ClearColor">

It looks like this code prevents GL_ACCUM_BUFFER_BIT from being used.
Admittedly, seeing as that isn't defined in any GLES headers, it's
probably OK, but I suppose it isn't *entirely* useless.