[Mesa-dev] [PATCH 01/10] build: Remove deprecated --with-driver= flag

[Kenneth Graunke]

On 08/17/2012 04:46 PM, Matt Turner wrote:
> ---
>  configure.ac |   37 ++++++-------------------------------
>  1 files changed, 6 insertions(+), 31 deletions(-)

These patches look okay to me.  I suspect the most contentious one will
be #5 (sensible defaults), as it hardcodes the Linux defaults and
removes the automatic OS/platform detection.  Removing the automatic
detection certainly simplifies things, and does force you to make a
conscious choice to do the right thing for your platform, which IMHO
isn't a bad thing.  I'm still hesistant to proceed with that, though.
Hopefully others can give acks/nacks.

Also, I question the value of --enable-xlib-glx.  It seems to me
--enable-glx should provide DRI-based GLX if --enable-dri is set, and
Xlib-based GLX if not.  The only reason I can think of for the
additional option is to make it easier to test the Xlib-based GLX code.
 I'm not aware of any drawbacks to the DRI-based solution.

For the series:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(but please wait for someone not on the Intel team to ack it)