[Mesa-dev] [PATCH 05/18] mesa/es: Remove redundant glCompressedTexImage3DOES target validation

Kenneth Graunke kenneth at whitecape.org
Mon Aug 20 22:18:51 PDT 2012


On 08/20/2012 10:12 PM, Kenneth Graunke wrote:
> On 08/20/2012 05:06 PM, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>>  src/mesa/main/APIspec.xml |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
>> index 1306ac7..991e373 100644
>> --- a/src/mesa/main/APIspec.xml
>> +++ b/src/mesa/main/APIspec.xml
>> @@ -2055,10 +2055,6 @@
>>  		<param name="imagesize" type="GLsizei"/>
>>  		<param name="data" type="const GLvoid *"/>
>>  	</proto>
>> -
>> -	<desc name="target">
>> -		<value name="GL_TEXTURE_3D_OES"/>
>> -	</desc>
>>  </template>
>>  
>>  <template name="CompressedTexSubImage3D">
> 
> I believe this will allow GL_PROXY_TEXTURE_3D to slip through.

...which you actually fix in the very next patch.  I'd just squash this
into patch 6, where you kill the rest of this stuff and do it right.

Not a big deal, but avoids a tiny bit of intermittent breakage.




More information about the mesa-dev mailing list