[Mesa-dev] [PATCH 2/2] i965: don't clear resolve map when doing fast depth clears.

[Eric Anholt]

Paul Berry <stereotype441 at gmail.com> writes:

> Previously, when performing a fast depth clear, we would also clear
> the miptree's resolve map.  This destroyed important information,
> since the resolve map contains information about needed resolves for
> all levels and layers of the miptree, whereas a depth clear only
> applies to a single level/layer combination at a time.  As a result,
> resolves would sometimes fail to occur, leading to incorrect
> rendering.
>
> Fixes rendering artifacts with shadow maps in Unigine Heaven and
> Unigine Sanctuary.

Nice catch!

However, isn't the issue really that we're incorrectly setting
needs_depth_resolve on layers/levels of the referenced mt that we're not
actually changing hiz state for, since they didn't get cleared?  It
seems like this fixes the current issue, but leaves that bug in place.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120822/90f9e0bd/attachment.pgp>