[Mesa-dev] [PATCH 05/12] mesa/es: Remove redundant vertex attrib pointer type validation

[Kenneth Graunke]

On 08/22/2012 07:26 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/main/APIspec.xml |   22 ----------------------
>  1 files changed, 0 insertions(+), 22 deletions(-)
> 
> diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
> index 1f6f35d..6d4ae0d 100644
> --- a/src/mesa/main/APIspec.xml
> +++ b/src/mesa/main/APIspec.xml
> @@ -1780,28 +1780,6 @@
>  		<param name="stride" type="GLsizei"/>
>  		<param name="pointer" type="const GLvoid *"/>
>  	</proto>
> -
> -	<desc name="type" error="GL_INVALID_VALUE">
> -		<value name="GL_BYTE"/>
> -		<value name="GL_UNSIGNED_BYTE"/>
> -		<value name="GL_SHORT"/>
> -		<value name="GL_UNSIGNED_SHORT"/>
> -		<value name="GL_FLOAT"/>
> -		<value name="GL_FIXED"/>
> -		<value name="GL_HALF_FLOAT_OES" category="OES_vertex_half_float"/>
> -		<value name="GL_UNSIGNED_INT_10_10_10_2_OES" category="OES_vertex_type_10_10_10_2"/>
> -		<value name="GL_INT_10_10_10_2_OES" category="OES_vertex_type_10_10_10_2"/>

GL_INT is missing from this list, meaning it used to be disallowed on
ES, but I don't see you filtering INT_BIT out for ES in patch #2.

According to the ES2 spec, GL_INT is not allowed as a type for
VertexAttribPointer.  In ES3, it /is/ allowed.

Aside from that, I agree, it appears to be redundant.

> -	</desc>
> -
> -	<desc name="type" category="OES_vertex_type_10_10_10_2">
> -		<value name="GL_UNSIGNED_INT_10_10_10_2_OES"/>
> -		<value name="GL_INT_10_10_10_2_OES"/>
> -
> -		<desc name="size">
> -			<value name="3"/>
> -			<value name="4"/>
> -		</desc>
> -	</desc>
>  </template>
>  
>  <template name="EnableVertexAttribArray">
>