[Mesa-dev] [PATCH 01/10] i965: Fix brw_link_shader to return false rather than NULL.

[Paul Berry]

On 24 August 2012 03:05, Kenneth Graunke <kenneth at whitecape.org> wrote:

> Fixes brw_shader.cpp:101:9: warning: converting to non-pointer type
> 'GLboolean {aka unsigned char}' from NULL [-Wconversion-null]
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>

Oh, thank you.  I keep getting this warning when I'm in the middle of other
things, saying to myself, "I should go fix that when I have a free moment",
and then forgetting.

Reviewed-with-great-enthusiasm-by: Paul Berry <stereotype441 at gmail.com>


> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
> b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index 86426e0..77e9392 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -98,7 +98,7 @@ brw_link_shader(struct gl_context *ctx, struct
> gl_shader_program *shProg)
>        struct gl_program *prog =
>          ctx->Driver.NewProgram(ctx, targets[stage], shader->base.Name);
>        if (!prog)
> -       return NULL;
> +       return false;
>        prog->Parameters = _mesa_new_parameter_list();
>
>        _mesa_generate_parameters_list_for_uniforms(shProg, &shader->base,
> --
> 1.7.11.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120824/9398ed74/attachment.html>