[Mesa-dev] [PATCH 3/7] r600g: fix evergreen 8x MSAA sample positions

[Marek Olšák]

On Thu, Aug 23, 2012 at 11:39 PM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 23 August 2012 10:42, Marek Olšák <maraeo at gmail.com> wrote:
>>
>> On Thu, Aug 23, 2012 at 6:42 PM, Paul Berry <stereotype441 at gmail.com>
>> wrote:
>> > On 22 August 2012 18:54, Marek Olšák <maraeo at gmail.com> wrote:
>> >>
>> >> The original samples positions took samples outside of the pixel
>> >> boundary,
>> >> leading to dark pixels on the edge of the colorbuffer, among other
>> >> things.
>> >
>> >
>> > Does this address the issues you were having with the error thresholds
>> > in
>> > the EXT_framebuffer_multisample piglit tests (Re: your Aug 13 email
>> > "[Piglit] [PATCH] ext_framebuffer_multisample: relax MSAA precision")?
>>
>> Yes, it does. The accuracy tests now pass for me.
>>
>> Marek
>
>
> Excellent.  Glad to hear it.

Sorry, the tests actually don't pass, I tested with the piglit patch
applied. :( However this patch reduces the error quite a lot, it's
just not enough. I guess I have to choose the sample positions very
carefully.

Marek