[Mesa-dev] [PATCH 1/7] i965: Drop manual hiz resolves in span rendering.

Ian Romanick idr at freedesktop.org
Mon Aug 27 17:36:51 PDT 2012


Nice work.  Patches 1 & 2 are

Acked-by: Ian Romanick <ian.d.romanick at intel.com>

and patches 3 through 7 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 08/26/2012 04:46 PM, Eric Anholt wrote:
> swrast uses MapRenderbuffer, which leads to intel_miptree_map, which does the
> depth resolve.
> ---
>   src/mesa/drivers/dri/intel/intel_span.c |   10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/intel/intel_span.c b/src/mesa/drivers/dri/intel/intel_span.c
> index b0dc720..3dc7f21 100644
> --- a/src/mesa/drivers/dri/intel/intel_span.c
> +++ b/src/mesa/drivers/dri/intel/intel_span.c
> @@ -117,8 +117,6 @@ static void
>   intel_span_resolve_buffers(struct intel_context *intel)
>   {
>      struct gl_context *ctx = &intel->ctx;
> -   struct intel_renderbuffer *draw_irb;
> -   struct intel_renderbuffer *read_irb;
>      struct intel_texture_object *tex_obj;
>
>      /* Resolve depth buffer of each enabled texture. */
> @@ -131,14 +129,6 @@ intel_span_resolve_buffers(struct intel_context *intel)
>   	 continue;
>         intel_miptree_all_slices_resolve_depth(intel, tex_obj->mt);
>      }
> -
> -   /* Resolve each attached depth buffer. */
> -   draw_irb = intel_get_renderbuffer(ctx->DrawBuffer, BUFFER_DEPTH);
> -   read_irb = intel_get_renderbuffer(ctx->ReadBuffer, BUFFER_DEPTH);
> -   if (draw_irb)
> -      intel_renderbuffer_resolve_depth(intel, draw_irb);
> -   if (read_irb != draw_irb && read_irb)
> -      intel_renderbuffer_resolve_depth(intel, read_irb);
>   }
>
>   /**
>




More information about the mesa-dev mailing list