[Mesa-dev] Mesa (master): i965/msaa: Add sample-alpha-to-coverage support for multiple render targets

[Anuj Phogat]

On Fri, Aug 24, 2012 at 9:17 AM, Eric Anholt <eric at anholt.net> wrote:
> Anuj Phogat <aphogat at kemper.freedesktop.org> writes:
>
>> Module: Mesa
>> Branch: master
>> Commit: e592f7df0361eb8b5c75944f0151c4e6b3f839dd
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e592f7df0361eb8b5c75944f0151c4e6b3f839dd
>>
>> Author: Anuj Phogat <anuj.phogat at gmail.com>
>> Date:   Wed Aug  1 16:32:06 2012 -0700
>>
>> i965/msaa: Add sample-alpha-to-coverage support for multiple render targets
>>     /* _NEW_BUFFERS */
>>     key->nr_color_regions = ctx->DrawBuffer->_NumColorDrawBuffers;
>> +  /* _NEW_MULTISAMPLE */
>> +   key->sample_alpha_to_coverage = ctx->Multisample.SampleAlphaToCoverage;
>
> You haven't flagged _NEW_MULTISAMPLE in the brw_tracked_state, despite
> your comment here.  This means the program won't get recompiled like you
> need when SampleAlphaToCoverage is enabled.
>
I misunderstood you earlier comment on my patch to add _NEW_MULTISAMPLE.
I'll post a small patch to fix it.

> (We don't generally comment about the state flag bits in the program key
> struct -- it's not the place you're looking at when reviewing the state
> flags that need to be set in the brw_tracked_state)
>
Yeah. That comment is probably redundant.