[Mesa-dev] [PATCH] i965/fs: Don't use brw->fragment_program in calculate_urb_setup().

Eric Anholt eric at anholt.net
Fri Aug 31 13:51:13 PDT 2012


Kenneth Graunke <kenneth at whitecape.org> writes:

> Reading brw->fragment_program is nonsensical in compiler code: it
> contains the currently active program (if any), not the one currently
> being compiled.  Attempting to access it may either lead to crashes
> (null pointer dereference if no program is active) or wrong results.
>
> Fixes piglit regressions since 9ef710575b914ddfc8e9a162d98ad554c1c217f7
> on pre-Sandybridge hardware.  The actual bug was created in commit
> 7b1fbc688999fd568e65211d79d7678562061594.
>
> NOTE: This is a candidate for the 9.0 and 8.0 branches.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54183
> Cc: Rico Tzschichholz <ricotz at t-online.de>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120831/aec99a05/attachment.pgp>


More information about the mesa-dev mailing list