[Mesa-dev] [PATCH] mesa: Disable GL_NV_primitive_restart extension in core contexts.

[Ian Romanick]

On 12/03/2012 12:34 AM, Kenneth Graunke wrote:
> The NV formulation of primitive restart is turned on/off with
> glEnableClientState/glDisableClientState.  These two functions don't
> exist in core contexts, which mean that GL_NV_primitive_restart is
> essentially useless.

I'd go one further... this extension requires non-existent 
functionality, so exposing it is just plain wrong.

This is a candidate for the 9.0 branch too.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> However, leaving it on causes oglconform's primitive-restart-nv tests to
> run in OpenGL 3.1 contexts, which results in them all failing.  This
> patch causes 29 subtests to go from "fail" to "not run".
> ---
>   src/mesa/main/extensions.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 9e23a66..5fbfe25 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -308,7 +308,7 @@ static const struct extension extension_table[] = {
>      { "GL_NV_light_max_exponent",                   o(dummy_true),                              GLL,            1999 },
>      { "GL_NV_packed_depth_stencil",                 o(EXT_packed_depth_stencil),                GL,             2000 },
>      { "GL_NV_point_sprite",                         o(NV_point_sprite),                         GL,             2001 },
> -   { "GL_NV_primitive_restart",                    o(NV_primitive_restart),                    GL,             2002 },
> +   { "GL_NV_primitive_restart",                    o(NV_primitive_restart),                    GLL,            2002 },
>      { "GL_NV_read_buffer",                          o(dummy_true),                              ES2,            2011 },
>      { "GL_NV_texgen_reflection",                    o(dummy_true),                              GLL,            1999 },
>      { "GL_NV_texture_barrier",                      o(NV_texture_barrier),                      GL,             2009 },
>