[Mesa-dev] [PATCH] mesa: print unsigned values with %u

Brian Paul brianp at vmware.com
Fri Dec 7 15:02:05 PST 2012


On 12/07/2012 03:27 PM, Matt Turner wrote:
> Otherwise messages say silly things like
>     glGetActiveUniformBlockiv(block index -1>= 0)
> ---
>   src/mesa/main/uniforms.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
> index 3f156bf..77b195e 100644
> --- a/src/mesa/main/uniforms.c
> +++ b/src/mesa/main/uniforms.c
> @@ -614,14 +614,14 @@ _mesa_UniformBlockBinding(GLuint program,
>
>      if (uniformBlockIndex>= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glUniformBlockBinding(block index %d>= %d)",
> +		  "glUniformBlockBinding(block index %u>= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }
>
>      if (uniformBlockBinding>= ctx->Const.MaxUniformBufferBindings) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glUniformBlockBinding(block binding %d>= %d)",
> +		  "glUniformBlockBinding(block binding %u>= %u)",
>   		  uniformBlockBinding, ctx->Const.MaxUniformBufferBindings);
>         return;
>      }
> @@ -667,7 +667,7 @@ _mesa_GetActiveUniformBlockiv(GLuint program,
>
>      if (uniformBlockIndex>= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glGetActiveUniformBlockiv(block index %d>= %d)",
> +		  "glGetActiveUniformBlockiv(block index %u>= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }
> @@ -750,7 +750,7 @@ _mesa_GetActiveUniformBlockName(GLuint program,
>
>      if (uniformBlockIndex>= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glGetActiveUniformBlockiv(block index %d>= %d)",
> +		  "glGetActiveUniformBlockiv(block index %u>= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list