[Mesa-dev] [PATCH 6/6] draw: fix/improve dirty state validation
brianp at vmware.com
Sat Dec 8 05:32:04 PST 2012
On 12/08/2012 03:48 AM, Jose Fonseca wrote:
> Reviewed-by: Jose Fonseca<jfonseca at vmware.com>
> Series looks excellent Brian. Thanks for nailing this issue. I never stop to be amazed on how state derivation bugs go unnoticed for so long, just because most apps ends up touch a lot of state at the same time. One could try to write piglit tests that draw something, change one bit of state, re-draw, but it would take a lot of tests to cover everything.
> Slight different issue -- you originally were looking into draw module and user buffer pointers -- is draw module actually properly flushing whenever user buffers are used? Or is that still outstanding?
That's separate. I have a fix for that too, but I need to rebase it
on top of these changes, retest, etc.
More information about the mesa-dev