[Mesa-dev] [PATCH] llvmpipe: remove unneeded draw_flush() calls

Brian Paul brianp at vmware.com
Mon Dec 10 09:39:45 PST 2012


These are redundant since we're calling draw_bind_fragment_shader()
and draw_set_mapped_constant_buffer() which have flush calls also.
---
 src/gallium/drivers/llvmpipe/lp_state_fs.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c
index dced5d2..ee4c6cd 100644
--- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
+++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
@@ -2312,8 +2312,6 @@ llvmpipe_bind_fs_state(struct pipe_context *pipe, void *fs)
    if (llvmpipe->fs == fs)
       return;
 
-   draw_flush(llvmpipe->draw);
-
    llvmpipe->fs = (struct lp_fragment_shader *) fs;
 
    draw_bind_fragment_shader(llvmpipe->draw,
@@ -2427,8 +2425,6 @@ llvmpipe_set_constant_buffer(struct pipe_context *pipe,
    if(llvmpipe->constants[shader][index] == constants)
       return;
 
-   draw_flush(llvmpipe->draw);
-
    /* note: reference counting */
    pipe_resource_reference(&llvmpipe->constants[shader][index], constants);
 
-- 
1.7.3.4



More information about the mesa-dev mailing list