[Mesa-dev] [PATCH] st/mesa: remove the prefix 'Gallium 0.4 on' from the renderer string

[Jose Fonseca]

This will break apps that expect the current to tweak their behavior.  Changing it now will cause pain to app developers and ourselves, and I honestly don't the good of it.

For good or bad we have these strings. So I'd prefer we focused on making our drivers rock solid so that app developers don't feel the need to detect and workaround issues in our drivers.

Jose

----- Original Message -----
> We already have the Mesa version in the version string, isn't that
> enough
> to detect Mesa?
> ---
>  src/mesa/state_tracker/st_cb_strings.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_cb_strings.c
> b/src/mesa/state_tracker/st_cb_strings.c
> index 2132379..3ce9fab 100644
> --- a/src/mesa/state_tracker/st_cb_strings.c
> +++ b/src/mesa/state_tracker/st_cb_strings.c
> @@ -39,8 +39,6 @@
>  #include "st_context.h"
>  #include "st_cb_strings.h"
>  
> -#define ST_VERSION_STRING "0.4"
> -
>  static const GLubyte *
>  st_get_string(struct gl_context * ctx, GLenum name)
>  {
> @@ -55,8 +53,7 @@ st_get_string(struct gl_context * ctx, GLenum name)
>     }
>  
>     case GL_RENDERER:
> -      util_snprintf(st->renderer, sizeof(st->renderer), "Gallium %s
> on %s",
> -               ST_VERSION_STRING,
> +      util_snprintf(st->renderer, sizeof(st->renderer), "%s",
>  	       screen->get_name( screen ));
>  
>        return (GLubyte *) st->renderer;
> --
> 1.7.10.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>