[Mesa-dev] Mesa (gles3): mesa: print unsigned values with %u

[Ian Romanick]

On 12/08/2012 11:25 AM, Matt Turner wrote:
> Module: Mesa
> Branch: gles3
> Commit: 6b8a9c43bb87f214782c280fa96847992032891b
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b8a9c43bb87f214782c280fa96847992032891b
>
> Author: Matt Turner <mattst88 at gmail.com>
> Date:   Fri Dec  7 14:26:04 2012 -0800
>
> mesa: print unsigned values with %u
>
> Otherwise messages say silly things like
>     glGetActiveUniformBlockiv(block index -1 >= 0)
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

This should just go directly to master.  Can you do that, and we can 
rebase it out of gles3 soon?

> ---
>
>   src/mesa/main/uniforms.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
> index 3f156bf..77b195e 100644
> --- a/src/mesa/main/uniforms.c
> +++ b/src/mesa/main/uniforms.c
> @@ -614,14 +614,14 @@ _mesa_UniformBlockBinding(GLuint program,
>
>      if (uniformBlockIndex >= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glUniformBlockBinding(block index %d >= %d)",
> +		  "glUniformBlockBinding(block index %u >= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }
>
>      if (uniformBlockBinding >= ctx->Const.MaxUniformBufferBindings) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glUniformBlockBinding(block binding %d >= %d)",
> +		  "glUniformBlockBinding(block binding %u >= %u)",
>   		  uniformBlockBinding, ctx->Const.MaxUniformBufferBindings);
>         return;
>      }
> @@ -667,7 +667,7 @@ _mesa_GetActiveUniformBlockiv(GLuint program,
>
>      if (uniformBlockIndex >= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glGetActiveUniformBlockiv(block index %d >= %d)",
> +		  "glGetActiveUniformBlockiv(block index %u >= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }
> @@ -750,7 +750,7 @@ _mesa_GetActiveUniformBlockName(GLuint program,
>
>      if (uniformBlockIndex >= shProg->NumUniformBlocks) {
>         _mesa_error(ctx, GL_INVALID_VALUE,
> -		  "glGetActiveUniformBlockiv(block index %d >= %d)",
> +		  "glGetActiveUniformBlockiv(block index %u >= %u)",
>   		  uniformBlockIndex, shProg->NumUniformBlocks);
>         return;
>      }
>
> _______________________________________________
> mesa-commit mailing list
> mesa-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-commit
>