[Mesa-dev] [PATCH 1/3] i965: Fix hiz resolves getting stomped by depth offset validation.

Eric Anholt eric at anholt.net
Tue Dec 18 15:03:38 PST 2012


Fixes all the remaining non-Z32F_S8 depthstencil-render-miplevels
tests in piglit.

---

This causes the other Z32F change in the series I sent out earlier
today to result in all depthstencil-render-miplevels tests passing.
My plan is to push this series before that one.

 src/mesa/drivers/dri/i965/brw_draw.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index cb8e682..faa29d1 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -436,17 +436,17 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
 
    intel_prepare_render(intel);
 
+   /* This workaround has to happen outside of brw_state_upload() because it
+    * may flush the batchbuffer for a blit, affecting the state flags.
+    */
+   brw_workaround_depthstencil_alignment(brw);
+
    /* Resolves must occur after updating renderbuffers, updating context state,
     * and finalizing textures but before setting up any hardware state for
     * this draw call.
     */
    brw_predraw_resolve_buffers(brw);
 
-   /* This workaround has to happen outside of brw_state_upload() because it
-    * may flush the batchbuffer for a blit, affecting the state flags.
-    */
-   brw_workaround_depthstencil_alignment(brw);
-
    /* Bind all inputs, derive varying and size information:
     */
    brw_merge_inputs( brw, arrays );
-- 
1.7.10.4



More information about the mesa-dev mailing list