[Mesa-dev] [PATCH 3/4] mesa/st: Implement GL_TIME_ELAPSED w/ PIPE_QUERY_TIMESTAMP.

[Brian Paul]

On 12/19/2012 04:26 PM, jfonseca at vmware.com wrote:
> From: José Fonseca<jose.r.fonseca at gmail.com>
>
> ARB/EXT_timer_query's definition of GL_TIME_ELAPSED match precisely the
> subtraction of two GL_TIMESTAMP queries.
>
> And for a lot of drivers, that's precisely how they have to implement
> internally -- by emitting two hardware timestamp queries.
>
> So, to simplify driver implementation, simply allow doing so in the state
> tracker.
>
> Eventually if no driver implements PIPE_QUERY_TIME_ELAPSED then we could
> retire it.
> ---
>   src/mesa/state_tracker/st_cb_queryobj.c |   85 ++++++++++++++++++++++++-------
>   src/mesa/state_tracker/st_cb_queryobj.h |    4 ++
>   src/mesa/state_tracker/st_context.h     |    1 +
>   src/mesa/state_tracker/st_extensions.c  |   11 ++--
>   4 files changed, 79 insertions(+), 22 deletions(-)

LGTM.

For 3&4: Reviewed-by: Brian Paul <brianp at vmware.com>