[Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

[Ian Romanick]

On 02/03/2012 02:11 AM, Eric Anholt wrote:
> On Wed,  1 Feb 2012 12:29:39 -0700, "Ian Romanick"<idr at freedesktop.org>  wrote:
>> From: Ian Romanick<ian.d.romanick at intel.com>
>>
>> A similar check was removed in 05ab8fc.  The check is not complete
>> redundand because some paths, such as
>> _mesa_meta_check_generate_mipmap_fallback, can get to
>> intel_renderbuffer_update_wrapper but not get to
>> intel_validate_framebuffer.  This occurs when trying to generate
>> mipmaps for GL_SLUMINANCE8 textures.
>
> Err, are you saying that glCheckFramebufferStatusEXT in the meta is not
> triggering intel_validate_framebuffer?  That seems Bad.

The last call to intel_renderbuffer_update_wrapper before the test case 
starts crying is not followed by a call to intel_validate_framebuffer or 
_mesa_CheckFramebufferStatusEXT.  The backtrace is below.  It appears 
that the texture is already bound to an FBO.  The expectation is that 
the glTexImage1D call will automatically update the framebuffer status 
based on any changes made to the texture.

#0  intel_renderbuffer_update_wrapper (intel=0x7ffff5511040, 
irb=0x2da4db0, image=0x2cd06d0, layer=0) at intel_fbo.c:471
#1  0x00007ffff6276968 in intel_render_texture (ctx=0x7ffff5511040, 
fb=0x28ec1b0, att=0x2c0f640) at intel_fbo.c:631
#2  0x00007ffff5e07b80 in check_rtt_cb (key=1, data=0x2c0f3f0, 
userData=0x7fffffffd250) at main/teximage.c:2236
#3  0x00007ffff5d95695 in _mesa_HashWalk (table=0x2929d30, 
callback=0x7ffff5e07a61 <check_rtt_cb>,
     userData=0x7fffffffd250) at main/hash.c:334
#4  0x00007ffff5e07c00 in _mesa_update_fbo_texture (ctx=0x7ffff5511040, 
texObj=0x2b91f90, face=0, level=0)
     at main/teximage.c:2263
#5  0x00007ffff5e086aa in teximage (ctx=0x7ffff5511040, dims=1, 
target=3552, level=0, internalFormat=35911, width=64,
     height=1, depth=1, border=0, format=6409, type=5121, 
pixels=0x2dc5b80) at main/teximage.c:2546
#6  0x00007ffff5e087a8 in _mesa_TexImage1D (target=3552, level=0, 
internalFormat=35911, width=64, border=0,
     format=6409, type=5121, pixels=0x2dc5b80) at main/teximage.c:2571