[Mesa-dev] [PATCH 1/4] dri: Clarify comments on InfoMessageF and ErrorMessageF macros.

Carl Worth cworth at cworth.org
Fri Feb 3 17:14:19 PST 2012


The description of ErrorMessageF was misleading in the case of
LIBGL_DEBUG being unset, (the previous comment could be understood to
mean the error should be printed, but the code does not print in this
case).

InfoMessageF previously had no comment at all.
---
 src/glx/dri_common.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c
index ed0b134..5096c1f 100644
--- a/src/glx/dri_common.c
+++ b/src/glx/dri_common.c
@@ -48,6 +48,10 @@
 #define RTLD_GLOBAL 0
 #endif
 
+/**
+ * Print informational message to stderr if LIBGL_DEBUG is set to
+ * "verbose".
+ */
 _X_HIDDEN void
 InfoMessageF(const char *f, ...)
 {
@@ -63,7 +67,8 @@ InfoMessageF(const char *f, ...)
 }
 
 /**
- * Print error to stderr, unless LIBGL_DEBUG=="quiet".
+ * Print error message to stderr if LIBGL_DEBUG is set to anything but
+ * "quiet", (do nothing if LIBGL_DEBUG is unset).
  */
 _X_HIDDEN void
 ErrorMessageF(const char *f, ...)
-- 
1.7.8.3



More information about the mesa-dev mailing list