[Mesa-dev] [PATCH 5/5] gallivm: enable stores of integer types.

[Jose Fonseca]

----- Original Message -----
> On Mon, Feb 6, 2012 at 7:47 PM, Jose Fonseca <jfonseca at vmware.com>
> wrote:
> > Dave,
> >
> > I really see no point of inferring anything when translating MOVs.
> > The src/dst value will need to be converted from/to a floating
> > point anyway so this is unnecessary complexity AFAICS. If you
> > believe this is really necessary please provide a concrete
> > example.
> 
> The problem is MOV from immediate, since immediates are stored as the
> correct internal type, so we don't get to infer the src in that case,
> then we try to MOV int4* to float4* and llvm crashes.

I see.

In that case I'd suggest you to:

- in lp_emit_immediate_soa() bitcast _all_ integer immediates to floats (i.e., bld->immediates[] is always of llvm type float, just like bld->temps[], and bld->outputs[], etc.).

- in emit_fetch_immediate() bitcast back to integer when stype == INT or UINT

This way there's less magic: all LLVM registers are of LLVM type (though some of then may contain integers as floats).  This would also work if one day we need to support indirect addressing of immediates.

Jose