[Mesa-dev] [PATCH] gallium: add PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

Jose Fonseca jfonseca at vmware.com
Tue Feb 7 08:59:11 PST 2012



----- Original Message -----
> On 02/07/2012 05:24 PM, Jose Fonseca wrote:
> > I'm not familiar enough with draw internals to tell whether your
> > changes are enough or not.
> > 
> > But I'm OK with this change as is, given that most drivers will not
> > advertise PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION, so
> > only those that do advertise need to be tested to ensure that
> > things are working correctly.
> > 
> > Is there a piglit test for QuadsFollowProvokingVertexConvention?
> > It's probably a good idea to have one piglit test that tests it
> > and draw clipped primitives w/ different fill modes.
> > 
> 
> glean's clipFlat tests this, with this patch nv50 and nvc0 will
> finally
> pass.
> 
> I tested drawing a clipped quad with softpipe with both the cap
> enabled
> and disabled and it looks like the draw change works.
> 
> So, I'll push it soon, then - r600 will get to profit from the cap
> too,
> as Marek already mentioned.

Sounds great to me.

Jose


More information about the mesa-dev mailing list