[Mesa-dev] [PATCH] st/mesa: fixup NDEBUG vs DEBUG causing debug path to get taken.

[Brian Paul]

On 02/08/2012 05:46 AM, Dave Airlie wrote:
> From: Dave Airlie<airlied at redhat.com>
>
>  From what I can see we were taking the debug path all the time,
> when we probably only want it for enable debug path.
>
> Signed-off-by: Dave Airlie<airlied at redhat.com>
> ---
>   src/mesa/state_tracker/st_atom.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c
> index e1eac81..d9cd4aa 100644
> --- a/src/mesa/state_tracker/st_atom.c
> +++ b/src/mesa/state_tracker/st_atom.c
> @@ -148,10 +148,10 @@ void st_validate_state( struct st_context *st )
>
>      /*printf("%s %x/%x\n", __FUNCTION__, state->mesa, state->st);*/
>
> -#ifdef NDEBUG
> -   if (0) {
> -#else
> +#ifdef DEBUG
>      if (1) {
> +#else
> +   if (0) {
>   #endif
>         /* Debug version which enforces various sanity checks on the
>          * state flags which are generated and checked to help ensure

LGTM.  I don't know if autoconf/scons is setting NDEBUG for release 
builds but they should definitely set DEBUG for debug builds.

-Brian