[Mesa-dev] [PATCH 1/2] i965: Report the failure message when failing to compile the fragment shader.

[Brian Paul]

On 02/12/2012 06:49 AM, nobled wrote:
> On Fri, Feb 10, 2012 at 12:42 AM, Eric Anholt<eric at anholt.net>  wrote:
>> We just abort later, but at least this should result in more
>> informative bug reports.
>> ---
>>   src/mesa/drivers/dri/i965/brw_fs.cpp |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> index 6ecaa6c..bf59da3 100644
>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> @@ -1844,6 +1844,9 @@ brw_wm_fs_emit(struct brw_context *brw, struct brw_wm_compile *c,
>>        prog->LinkStatus = false;
>>        ralloc_strcat(&prog->InfoLog, v.fail_msg);
>>
>> +      _mesa_problem(NULL, "Failed to compile fragment shader: %s\n",
> We should pass&brw->intel.ctx here instead of null, right?

The context argument to _mesa_problem() has never actually been used 
so it's not important.

If someone wanted to submit a patch to remove it that'd be fine.

-Brian