[Mesa-dev] [PATCH 1/4] vl: add a median filter for noise reduction

[Christian König]

On 13.02.2012 01:55, Andy Furniss wrote:
> Christian König wrote:
>> This is a shader based median filter, generally
>> used for noise reduction, it could still need some
>> improvements, but should usually work out of the box.
>
> Hi Christian.
>
> I haven't really tested these properly yet, but did find a small issue 
> with low strength denoise and mplayer.
>
> -vo vdpau:denoise=0.1
>
> vl/vl_median_filter.c:252:vl_median_filter_init: Assertion `size > 0 
> && size < 20' failed.
>
> 0.2 and 0.3
>
> tgsi/tgsi_ureg.c:891:ureg_emit_dst: Assertion `dst.File != 
> TGSI_FILE_CONSTANT' failed.
>
> 0.4 and above are OK.
>
>
Hi Andy,

thanks for testing, unfortunately I only tested 0.5 and 1.0 strength. 
Everything below 0.4 resulted in a median filter window of either zero 
or one, and both values doesn't make any sense.

Patch to fix this is underway,
Christian.