[Mesa-dev] [PATCH 1/3] st/vdpau: remove unnecessary tracing and adjust tracing levels a bit

[Christian König]

On 13.02.2012 16:05, Maarten Lankhorst wrote:
> Op 13-02-12 14:36, Christian König schreef:
>> Tracing function entry/exits is a bit pointless
>> when VDPAU_TRACE=1 does the same thing.
>>
>> Signed-off-by: Christian König<deathsimple at vodafone.de>
>> ---
>>   src/gallium/state_trackers/vdpau/decode.c       |   10 ----------
>>   src/gallium/state_trackers/vdpau/device.c       |    9 ---------
>>   src/gallium/state_trackers/vdpau/mixer.c        |   10 +++-------
>>   src/gallium/state_trackers/vdpau/output.c       |    9 ---------
>>   src/gallium/state_trackers/vdpau/presentation.c |   12 +-----------
>>   src/gallium/state_trackers/vdpau/query.c        |   16 
>> ----------------
>>   src/gallium/state_trackers/vdpau/surface.c      |    2 --
>>   7 files changed, 4 insertions(+), 64 deletions(-)
>>
> Mostly looks good to me, except you may want to change the things you 
> elevated to ERR to WARN,
> since it's just a parameter validation that fails, which is probably 
> an application problem, not an
> internal error. :)
Good idea, fixed.

Christian.