[Mesa-dev] [PATCH] i915: Set swrast_texture_image::Buffer and ::Map during swrast mapping

Eric Anholt eric at anholt.net
Thu Feb 16 15:48:25 PST 2012

On Tue, 14 Feb 2012 10:57:17 -0800, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> Before calling _tnl_run_pipeline, the i915 driver maps all textures
> used in vertex shaders (via intel_tex_map_images).  Later run_vp tries
> to map the textures again (via _swrast_map_texture).  However, this
> just replaces the actual mappings with NULL pointers.  When the
> pointers are dereferened, a segfault occurs.
> Setting swrast_texture_image::Buffer in intel_tex_map_images works
> around the problem, but I have a hard time believing this is the right
> fix.

Seems to me like the swrast map-things-for-texturing should be using
MapTextureImage.  Then we wouldn't need the intel
pre-_tnl_run_pipeline() mapping.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120216/34ae89f0/attachment.pgp>

More information about the mesa-dev mailing list