[Mesa-dev] [PATCH] i915: Initialize swrast_texture_image structure fields.

[Eric Anholt]

On Thu, 16 Feb 2012 22:57:32 -0800, Paul Berry <stereotype441 at gmail.com> wrote:
> Commit 980f6f1 (mesa: move gl_texture_image::Width/Height/DepthScale
> fields to swrast) moved the initialization of the Width, Height, and
> DepthScale fields to _swrast_alloc_texture_image_buffer().  However,
> i915 doesn't call this function because it performs its own buffer
> allocation.  As a result, the Width, Height, and DepthScale fields
> weren't getting initialized properly, and some operations requiring
> swrast would fail.
> 
> This patch ensures that Width, Height, and DepthScale are properly
> initialized by separating the code that sets them into a new function,
> _swrast_init_texture_image(), which is called by
> intel_alloc_texture_image_buffer() as well as
> _swrast_alloc_texture_image_buffer().  It also moves the
> initialization of _IsPowerOfTwo into this function.
> 
> Fixes piglit test fbo/fbo-cubemap on i915.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120217/2fa9c494/attachment.pgp>