[Mesa-dev] [PATCH 1/3] mesa: add missing return after _mesa_error() in update_array()

Kenneth Graunke kenneth at whitecape.org
Mon Feb 20 11:08:23 PST 2012


On 02/19/2012 06:53 PM, Brian Paul wrote:
> From: Brian Paul<brianp at vmware.com>
>
> NOTE: This is a candidate for the 8.0 branch.
> ---
>   src/mesa/main/varray.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> index 77c1d7d..dfe5064 100644
> --- a/src/mesa/main/varray.c
> +++ b/src/mesa/main/varray.c
> @@ -185,6 +185,7 @@ update_array(struct gl_context *ctx,
>          (type == GL_UNSIGNED_INT_2_10_10_10_REV ||
>           type == GL_INT_2_10_10_10_REV)&&  size != 4) {
>         _mesa_error(ctx, GL_INVALID_OPERATION, "%s(size=%d)", func, size);
> +      return;
>      }
>
>      ASSERT(size<= 4);

Series looks good to me too.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list