[Mesa-dev] [PATCH] gallivm: Fix TGSI_OPCODE_ARR's translation.

Dave Airlie airlied at gmail.com
Mon Feb 20 13:05:09 PST 2012

On Mon, Feb 20, 2012 at 8:51 PM,  <jfonseca at vmware.com> wrote:
> From: José Fonseca <jfonseca at vmware.com>
> Like TGSI_OPCODE_ARL, destination should be an integer.
> This fixes invalid LLVM IR on an internal state tracker (currently Mesa
> never emits this opcode).
> In the future consider making ADDR register also a integer-as-float array,
> like all other register kinds, or simply replace ADDR & ARR/ARL with
> integer temp and instructions.

Reviewed-by: Dave Airlie <airlied at redhat.com>

Just seems better to take the hit of doing the FPtoSI once rather than
each index access taking an FPtoSI.

When we turn on the integer opcodes properly, mesa st will product
UARL anyways, and I won't see any FP->SI at all.


More information about the mesa-dev mailing list