[Mesa-dev] [PATCH] gallium: Adds PIPE_SHADER_CAP_VARYINGS_PACKING_CONSTRAINTS

vincent vljn at ovi.com
Sat Feb 25 07:37:08 PST 2012


Le samedi 25 février 2012 à 10:26 -0500, Brian Paul a écrit :
> On Fri, Feb 24, 2012 at 2:44 PM, Vincent Lejeune <vljn at ovi.com> wrote:
> > v2: remove underscore between NO and PERSPECTIVE in PIPE_PACKING_CONSTRAINT_SMOOTH_NO_PERSPECTIVE_MIXED
> 
> Any particular reason why?  I think it reads easier with the underscore.
> 
> -Brian

Christoph pointed out that the underscore could lead to
misinterpretation of the meaning of the symbol, ie one could reads
PIPE_PACKING_CONSTRAINT_SMOOTH_NO_PERSPECTIVE_MIXED as (SMOOTH NO)
(PERSPECTIVE MIXED). Besides it was not consistent with Mesa enum
(PACKING_CONSTRAINT_SMOOTH_NOPERSPECTIVE_MIXED).

Vincent



More information about the mesa-dev mailing list