[Mesa-dev] [Bug 46631] It's really hard to hit the fast path for the fallback glReadPixels code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46631

José Fonseca <jfonseca at vmware.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jfonseca at vmware.com

--- Comment #2 from José Fonseca <jfonseca at vmware.com> 2012-02-26 04:55:54 PST ---
The transferOps change looks great to me. Good catch.

I'm unsure about LUMINANCE though.

The glReadPixels manpage indeed says that reading from RGBA renderbuffer to
LUMINANCE pixels, the resulting luminance values should have the addition of
R+G+B. But:

b) LUMINANCE -> LUMINANCE should still be a ordinary memcpy, and your change
would prevent that

c) _mesa_format_matches_format_and_type should already fail for LUMINANCE ->
RGB or RGB -> LUMINANCE . If it doesn't that there's where it needs to be
fixed.

So I'd suggest you, to split the transferOps change and luminance in two
patches, and provide a concrete example where the wrong things was being done
for luminance.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.