[Mesa-dev] st_draw.c regression

Brian Paul brianp at vmware.com
Wed Feb 29 14:34:01 PST 2012

Hi Dave,

This commit has caused a few regressions with the vmware svga driver:

commit 72931ca4b9fb1002f5b62b74f7f7f32e94e80fde
Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Feb 9 19:44:55 2012 +0000

     st/mesa: don't unreference user attribs up front.

     postpone unreferences until end of function, as the ones in use will
     get naturally dereferenced.

     Reviewed-by: Brian Paul <brianp at vmware.com>
     Signed-off-by: Dave Airlie <airlied at redhat.com>

The piglit draw-batch, quad-invariance and lodbias tests (maybe 
others) are failing on an assertion in the driver because the 
pipe->redefine_user_buffer() function isn't getting called.  It seems 
to be caused by st->user_attrib[i].buffer being NULL where it used to 
be non-null before your change.

Do you mind if I just revert this for now?


More information about the mesa-dev mailing list