[Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

[Ian Romanick]

On 01/03/2012 11:40 AM, Adam Jackson wrote:
> There's no reason to only force the visual to be on the default screen,
> and in fact good reason not to.

Is the visual ID enough information to uniquely identify it?  I may be 
mistaken (and horribly ignorant in this area), but I thought the visual 
ID namespace was per-screen, not per-display.

> Signed-off-by: Adam Jackson<ajax at redhat.com>
> ---
>   src/glx/drisw_glx.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c
> index 2d83a50..833ea7d 100644
> --- a/src/glx/drisw_glx.c
> +++ b/src/glx/drisw_glx.c
> @@ -87,9 +87,8 @@ XCreateDrawable(struct drisw_drawable * pdp,
>      XChangeGC(dpy, pdp->swapgc, GCGraphicsExposures,&gcvalues);
>
>      /* visual */
> -   visTemp.screen = DefaultScreen(dpy);
>      visTemp.visualid = visualid;
> -   visMask = (VisualScreenMask | VisualIDMask);
> +   visMask = VisualIDMask;
>      pdp->visinfo = XGetVisualInfo(dpy, visMask,&visTemp,&num_visuals);
>
>      /* create XImage */