[Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

Eric Anholt eric at anholt.net
Tue Jan 3 18:56:18 PST 2012


On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry <stereotype441 at gmail.com> wrote:
> On 3 January 2012 18:16, Eric Anholt <eric at anholt.net> wrote:
> 
> >
> > This series is Reviewed-by: Eric Anholt <eric at anholt.net>
> >
> > With this and the fix I have for glGetTransformFeedbackVarying(), I
> > think we should be passing the oglc tests, except for one more case:
> > They try to ask for whole arrays to be fed back, without [] in the
> > declaration.  The clearest text I could find on this point was a
> > RESOLUTION: in the spec, but it kind of sounded to me like the
> > resolution was about working around "how to I get feedback from my huge
> > amount of varying data when I have so few TFB attributes available?"
> > Did you end up testing whether other drivers accepted non-subscripted
> > TFB varyings for varying arrays?
> >
> 
> No, I didn't write any tests of non-subscripted arrays.  My interpretation
> of the spec had been that they weren't allowed, but now that I'm re-reading
> it, I'm reconsidering.  I'll investigate on the nVidia proprietary linux
> driver and let you know what I find out.
> 
> Do you have Piglit tests for glGetTransformFeedbackVarying()?  I was
> starting to write some, but it was slow going and I don't want to duplicate
> effort.

Nope, I was meaning to get at least a test of the particular piece of
spec I was hung up on (GetTFVarying reflecting linked state, not next
state), and didn't get to it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120103/da41eb6f/attachment.pgp>


More information about the mesa-dev mailing list